-
Notifications
You must be signed in to change notification settings - Fork 855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Heisenberg #1525
[WIP] Heisenberg #1525
Conversation
writing exchange calculation functions
writing functions
fixing functions
organizing functions
reformatting functions
Thanks @ncfrey ! |
I propose that you name the pymatgen wrappers around vampire "lestat". :-) |
Looks pretty good, some tests need to be updated (e.g. see test_round_magmoms in CollinearMagneticStructureAnalyzerTest), a few minor PEP8 violations (mostly line length), HeisenbergScreener class definition has extraneous parentheses etc. I haven't had a look at test coverage yet. Overall seems v high quality though + almost ready to merge. Thanks for the good code comments, made reviewing it easy! |
Thanks for the review Matt! Working on those fixes now. |
Find it really weird that ReactionDiagramTest failed here ... there's nothing in this PR that should affect that. |
Summary
@mkhorton
New functionality to take low energy magnetic orderings, map them to a Heisenberg model, compute exchange parameters, and perform Monte Carlo with the VAMPIRE package to calculate critical temperatures.
Additional dependencies introduced (if any)
TODO (if any)