Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plotting of Multicenter COBIs #2926

Merged
merged 45 commits into from
Mar 16, 2024

Conversation

JaGeo
Copy link
Member

@JaGeo JaGeo commented Mar 31, 2023

Summary

Lobster now also has options to compute multi-center interactions. This leads to a different format of the COBICAR.lobster (e.g., no average COBI is included) and the labels of the bonds are different. At this stage, I can already plot this different format but no tests are included so far. Bond lengths are missing in this output. I might add a computation of those based on the site index and cell number of the interacting atoms.

TODO:

  • Tests for input/output modules
  • Tests for from_ and as_dict options of CompleteCohp
  • Tests for from_file of CompleteCohp
  • Bond length computation from cell information (cannot be done without structure. Will therefore not be done)
  • Code simplification (e.g., many if clauses at the moment, probably simplifications are possible)
  • check recomputed average cobi in detail
  • test spin polarization in detail
  • Extend from three to really any multicenter bond

@JaGeo
Copy link
Member Author

JaGeo commented May 16, 2023

Just as a warning that this might sit here for a longer time. I discovered an issue for the multi-center COBI computations in Lobster for the spin-polarized case during the plotting implementation. I will wait until there is a new Lobster version that can generate useful test data.

@JaGeo
Copy link
Member Author

JaGeo commented Sep 10, 2023

Will try to finalize a first implementation soon. I have not forgotten about this pull request.

@JaGeo JaGeo changed the title [WIP]: Plotting of Multicenter COBIs Plotting of Multicenter COBIs Mar 16, 2024
@JaGeo
Copy link
Member Author

JaGeo commented Mar 16, 2024

@janosh if you have some time to review this, this would be awesome. If we don't merge it soon, this will never get merged as tons of merge conflicts show up very fast here in pymatgen and it would be sad as it was a lot of work ...

Copy link
Member

@janosh janosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! i renamed multicenter_cobis to multi_center_cobis since it was flagged by cSpell. let me know if this negatively affects downstream code

@janosh janosh added enhancement A new feature or improvement to an existing one io Input/output functionality lobster Lobster package (Local Orbital Basis Suite Towards Electronic-Structure Reconstruction) labels Mar 16, 2024
@JaGeo
Copy link
Member Author

JaGeo commented Mar 16, 2024

@janosh , The renaming is fine as it is not used yet anywhere.

@janosh janosh merged commit e78fd68 into materialsproject:master Mar 16, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A new feature or improvement to an existing one io Input/output functionality lobster Lobster package (Local Orbital Basis Suite Towards Electronic-Structure Reconstruction)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants