Skip to content

Species parse oxi state from symbol str#2998

Merged
janosh merged 5 commits into
masterfrom
species-parse-oxi-state-from-symbol-str
May 18, 2023
Merged

Species parse oxi state from symbol str#2998
janosh merged 5 commits into
masterfrom
species-parse-oxi-state-from-symbol-str

Conversation

@janosh

@janosh janosh commented May 18, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Closes #2997.

Species("O-").oxi_state
>>> -1

Species("Fe2+").oxi_state
>>> 2

@janosh janosh added the enhancement A new feature or improvement to an existing one label May 18, 2023
@janosh janosh enabled auto-merge (squash) May 18, 2023 00:26
@janosh janosh requested a review from shyuep May 18, 2023 00:26
@janosh
check symbol is str before indexing
622a08a 
and fix symbol type hint to account for str | Element  | Species
@janosh janosh mentioned this pull request May 18, 2023
Merged
@janosh janosh merged commit ad8e6e7 into master May 18, 2023
@janosh janosh deleted the species-parse-oxi-state-from-symbol-str branch May 18, 2023 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shyuep shyuep Awaiting requested review from shyuep

Assignees

No one assigned

Labels

enhancement A new feature or improvement to an existing one

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Species should parse oxi state from strings like "O2-"

1 participant

@janosh