Fix StructureMoleculeComponent
legend if same element has multiple oxi states
#339
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #338.
This is a WIP to start gathering feedback. As suggested by @yang-ruoxi, this first step splits every oxi state into its own legend label without affecting the site colors. I.e. different oxi states still have the same color in the structure.
Suggestion: Make negative oxi states slightly darker, positive ones slightly brighter and combine different oxi states for the same element into 1 wider label.
This PR requires upstream changes in pymatgen: materialsproject/pymatgen#2998 i.e. we can't put this into prod until pymatgen cuts a new release.
@mkhorton If you have a minute, could you let me know if there's any problem with making
StructureMoleculeComponent.get_scene_and_legend()
non-static? See e418cae.Here's what this PR looks like for the problematic structure reported by @ardunn on matsci.org.