Deprecate from_string
#3158
Merged
Deprecate from_string
#3158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add deprecated from_string fallback for backwards compatibility
janosh
added
api
janosh
force-pushed
the
deprecate-from-string
branch
from
2361644
to
5139abd
Compare
4 tasks
wanghan-iapcm
pushed a commit
to deepmodeling/dpgen
that referenced
this pull request
Oct 31, 2023
#1302) To be compatible with old and new versions of Pymatgen (materialsproject/pymatgen#3158) --------- Signed-off-by: Levi Zhou <31941107+ZhouXY-PKU@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some classes have static method
from_string(Poscar,CifParser, ...), other'sfrom_str(Structure,Molecule, ...).from_stris shorter and clear enough, so rename methods to that and add deprecatedfrom_stringfallbacks for backwards compatibility.