Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate overlooked from/as_..._string methods #3295

Merged
merged 4 commits into from
Sep 2, 2023

Conversation

janosh
Copy link
Member

@janosh janosh commented Sep 2, 2023

f01d38d rename variables: toks->tokens
42b7451 deprecate overlooked from/as_..._string methods (these were missed in #3230 and #3158 due to extra characters between from_..._str.

@janosh janosh added the deprecation Code deprecations label Sep 2, 2023
@janosh janosh enabled auto-merge (squash) September 2, 2023 04:07
…ment: 'self'

    @classmethod
    @np.deprecate(message="Use as_xyz_str instead")
    def as_xyz_string(cls, *args, **kwargs):  # noqa: D102
>       return cls.as_xyz_str(*args, **kwargs)
@janosh janosh merged commit 387dbf4 into master Sep 2, 2023
21 checks passed
@janosh janosh deleted the missing-from-string-deprecations branch September 2, 2023 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Code deprecations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant