Skip to content

Deprecate overlooked from/as_..._string methods#3295

Merged
janosh merged 4 commits intomasterfrom
missing-from-string-deprecations
Sep 2, 2023
Merged

Deprecate overlooked from/as_..._string methods#3295
janosh merged 4 commits intomasterfrom
missing-from-string-deprecations

Conversation

@janosh
Copy link
Member

@janosh janosh commented Sep 2, 2023

f01d38d rename variables: toks->tokens
42b7451 deprecate overlooked from/as_..._string methods (these were missed in #3230 and #3158 due to extra characters between from_..._str.

@janosh janosh added the deprecation Code deprecations label Sep 2, 2023
@janosh janosh enabled auto-merge (squash) September 2, 2023 04:07
…ment: 'self'

    @classmethod
    @np.deprecate(message="Use as_xyz_str instead")
    def as_xyz_string(cls, *args, **kwargs):  # noqa: D102
>       return cls.as_xyz_str(*args, **kwargs)
@janosh janosh merged commit 387dbf4 into master Sep 2, 2023
@janosh janosh deleted the missing-from-string-deprecations branch September 2, 2023 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecation Code deprecations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant