Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keyword in_place: bool = True to SiteCollection.replace_species #3224

Merged
merged 5 commits into from
Aug 5, 2023
Merged

Add keyword in_place: bool = True to SiteCollection.replace_species #3224

merged 5 commits into from
Aug 5, 2023

Conversation

janosh
Copy link
Member

@janosh janosh commented Aug 5, 2023

3c92cd5 add @AbstractMethod copy() to SiteCollection
41e1214 add in_place: bool = True to SiteCollection.replace_species and return modified structure
5ddc5c4 mypy disable_error_code = "annotation-unchecked"
48fe062 add TestIStructure.test_replace_species()

@janosh janosh added enhancement A new feature or improvement to an existing one core Pymatgen core labels Aug 5, 2023
@janosh janosh enabled auto-merge (squash) August 5, 2023 16:32
@janosh janosh merged commit 27fb64b into master Aug 5, 2023
29 checks passed
@janosh janosh deleted the replace_species-in_place-kwarg branch August 5, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core Pymatgen core enhancement A new feature or improvement to an existing one
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@janosh