Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lattice property params_dict #3239

Merged
merged 5 commits into from
Aug 14, 2023
Merged

Conversation

janosh
Copy link
Member

@janosh janosh commented Aug 13, 2023

16be051 add Lattice property params_dict
47699ef use new prop in Lattice.as_dict
069852f test keys in TestLattice.test_to_from_dict
41a424d add TestLattice.test_parameters

@janosh janosh added enhancement A new feature or improvement to an existing one ux User experience labels Aug 13, 2023
@janosh janosh enabled auto-merge (squash) August 13, 2023 23:38
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (182ccbf) 74.62% compared to head (41a424d) 74.62%.

❗ Current head 41a424d differs from pull request most recent head 6cdd0da. Consider uploading reports for the commit 6cdd0da to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3239      +/-   ##
==========================================
- Coverage   74.62%   74.62%   -0.01%     
==========================================
  Files         230      230              
  Lines       69403    69406       +3     
  Branches    16161    16161              
==========================================
+ Hits        51795    51796       +1     
- Misses      14533    14534       +1     
- Partials     3075     3076       +1     
Files Changed Coverage Δ
pymatgen/core/lattice.py 93.77% <100.00%> (+0.03%) ⬆️
pymatgen/io/lammps/data.py 96.96% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janosh janosh merged commit 54e2b65 into master Aug 14, 2023
28 checks passed
@janosh janosh deleted the add-lattice-prop-params-dict branch August 14, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A new feature or improvement to an existing one ux User experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants