Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix reciprocal_density in MPHSEBSSet and tests #3499

Merged
merged 2 commits into from
Dec 6, 2023
Merged

fix reciprocal_density in MPHSEBSSet and tests #3499

merged 2 commits into from
Dec 6, 2023

Conversation

fraricci
Copy link
Contributor

@fraricci fraricci commented Dec 6, 2023 •
edited by janosh
Loading

This implements the fix proposed in and closes #3492.

janosh
janosh approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@janosh janosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fraricci! 👍

@janosh janosh merged commit 2439dea into materialsproject:master Dec 6, 2023
22 checks passed
@janosh janosh added io Input/output functionality fix Bug fix PRs vasp Vienna Ab initio Simulation Package labels Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janosh janosh janosh approved these changes

Assignees
No one assigned
Labels
fix Bug fix PRs io Input/output functionality vasp Vienna Ab initio Simulation Package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

reciprocal_density not working in MPHSEBSSet
2 participants
@fraricci @janosh