Define arithmetic ops __add__ __sub__ __mul__ __neg__ __eq__ for PhononDos with tests
#3511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…raise", "warn", "ignore"] = "raise"
rename single-letter variables
add test_add test_sub test_mul test_eq test_str
janosh
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b98e12f
PhononBSPlotter.plot_compare()add keywordon_incompatible: Literal["raise", "warn", "ignore"] = "raise"3145126 add return type to
PhononDosmethod doc strings6072af8 define arithmetic dunder methods for
PhononDos__add____sub____mul____neg____eq__47addac test
PhononDosarithmetic ops and equality in