-
Notifications
You must be signed in to change notification settings - Fork 850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert mistaken Cohp.has_antibnd_states_below_efermi
rename
#3750
Conversation
WalkthroughThe update involves a renaming of a function within the pymatgen library, specifically in the electronic structure module related to COHP analysis. The original function name Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (2)
Additional comments not posted (6)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Windows tests are failing. Not sure why |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, sorry about that! 🤦 let's see if anything else broke before making a hot fix release
CI error is unrelated:
fatal: unable to access 'https://gitlab.com/ase/ase/': The requested URL returned error: 502
Will try to install from the repo to check all tests in LobsterPy as well... ;) |
Cohpl.has_antibnd_states_below_efermi
rename
All fine from LobsterPy side now. Thanks! |
Cohpl.has_antibnd_states_below_efermi
renameCohp.has_antibnd_states_below_efermi
rename
closes #3744
the rename of
Cohpl.has_antib(''->a)nd_states_below_efermi
confuses it's purpose and broke