-
Notifications
You must be signed in to change notification settings - Fork 850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add is_radioactive
property to Element class
#3804
Changes from 4 commits
63aa972
61f712b
327869e
fc66bdf
c06a24c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -237,6 +237,7 @@ def test_attributes(self): | |||||
("U", "Pu"): "is_actinoid", | ||||||
("Si", "Ge"): "is_metalloid", | ||||||
("O", "Te"): "is_chalcogen", | ||||||
("Tc", "Po"): "is_radioactive", | ||||||
} | ||||||
|
||||||
for key, val in is_true.items(): | ||||||
|
@@ -607,4 +608,4 @@ def test_get_el_sp(): | |||||
def test_element_type(): | ||||||
assert isinstance(ElementType.actinoid, Enum) | ||||||
assert isinstance(ElementType.metalloid, Enum) | ||||||
assert len(ElementType) == 17 | ||||||
assert len(ElementType) == 18 | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Update the expected count of The test for the length of the - assert len(ElementType) == 18
+ assert len(ElementType) == 19 Committable suggestion
Suggested change
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add tests for the new
is_radioactive
property.It seems that tests for the newly introduced
is_radioactive
property are missing. Would you like me to help generate these tests or should I open a GitHub issue to track this task?