fix: auth middleware

mateusasferreira · Dec 2, 2021 · bf59b49 · bf59b49
1 parent 1a81ffa
commit bf59b49
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/__tests__/unit/ensureAuthenticated.test.ts b/__tests__/unit/ensureAuthenticated.test.ts
@@ -20,6 +20,11 @@ beforeEach(() => {
 
 describe('Ensure authentication middleware', () => {
   it('should respond with 403 status if no headers are provided', () => {
+
+    mockRequest = {
+      headers: {}
+    }
+
     ensureAuthenticated(mockRequest as Request, mockResponse as Response, nextFunction as NextFunction)
 
     expect(mockResponse.status).toBeCalledWith(403)

diff --git a/src/middlewares/ensureAuthenticated.ts b/src/middlewares/ensureAuthenticated.ts
@@ -3,11 +3,9 @@ import jwt from 'jsonwebtoken'
 
 // eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
 export default function ensureAuthenticated(req: Request, res: Response, next: NextFunction){
-	const {headers} = req
-
-	//returns response so tests dont crash when mocking express
-	if(!headers) return res.status(403).json({message: 'Missing authentication token'})
-
+
+	if(!req.headers['authorization']) return res.status(403).json({message: 'Missing authentication token'})
+
 	const [,token] = req.headers['authorization'].split(' ')
 
 	jwt.verify(token, process.env.JWT_SECRET, function(err, decoded){