Merge pull request #144 from ReeceM/fix/issue-143-instatiate-ignition

Fix/issue 143 instatiate ignition
mateusjunges · Oct 18, 2019 · 9e06928 · 9e06928
2 parents 97684cc + d2fb563
commit 9e06928
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 12 deletions.
diff --git a/composer.json b/composer.json
@@ -21,7 +21,8 @@
     "require-dev": {
         "orchestra/testbench": "^3.6|^3.7|^3.8",
         "phpunit/phpunit": "^7.0|^8.0",
-        "predis/predis": "^1.1"
+        "predis/predis": "^1.1",
+        "facade/ignition": "^1.4"
     },
     "license": "MIT",
     "authors": [

diff --git a/src/ACLServiceProvider.php b/src/ACLServiceProvider.php
@@ -116,17 +116,15 @@ public function loadTranslations()
      */
     public function registerSolutionProviders(): void
     {
-        if (! $this->app->runningUnitTests()) {
-            $this->app->make(SolutionProviderRepository::class)->registerSolutionProviders([
-                \Junges\ACL\Exceptions\Solutions\Providers\MissingUsersTraitSolutionProvider::class,
-                \Junges\ACL\Exceptions\Solutions\Providers\MissingGroupsTraitSolutionProvider::class,
-                \Junges\ACL\Exceptions\Solutions\Providers\MissingPermissionsTraitSolutionProvider::class,
-                \Junges\ACL\Exceptions\Solutions\Providers\MissingACLWildcardsTraitSolutionProvider::class,
-                \Junges\ACL\Exceptions\Solutions\Providers\NotInstalledSolutionProvider::class,
-                \Junges\ACL\Exceptions\Solutions\Providers\GroupDoesNotExistSolutionProvider::class,
-                \Junges\ACL\Exceptions\Solutions\Providers\PermissionDoesNotExistSolutionProvider::class,
-            ]);
-        }
+        $this->app->make(SolutionProviderRepository::class)->registerSolutionProviders([
+            \Junges\ACL\Exceptions\Solutions\Providers\MissingUsersTraitSolutionProvider::class,
+            \Junges\ACL\Exceptions\Solutions\Providers\MissingGroupsTraitSolutionProvider::class,
+            \Junges\ACL\Exceptions\Solutions\Providers\MissingPermissionsTraitSolutionProvider::class,
+            \Junges\ACL\Exceptions\Solutions\Providers\MissingACLWildcardsTraitSolutionProvider::class,
+            \Junges\ACL\Exceptions\Solutions\Providers\NotInstalledSolutionProvider::class,
+            \Junges\ACL\Exceptions\Solutions\Providers\GroupDoesNotExistSolutionProvider::class,
+            \Junges\ACL\Exceptions\Solutions\Providers\PermissionDoesNotExistSolutionProvider::class,
+        ]);
     }
 
     /**

diff --git a/tests/TestCase.php b/tests/TestCase.php
@@ -5,6 +5,7 @@
 use Junges\ACL\ACLServiceProvider;
 use Junges\ACL\ACLAuthServiceProvider;
 use Illuminate\Database\Schema\Blueprint;
+use Facade\Ignition\IgnitionServiceProvider;
 use Orchestra\Testbench\TestCase as Orchestra;
 
 class TestCase extends Orchestra
@@ -93,6 +94,7 @@ public function getPackageProviders($app)
         return [
             ACLServiceProvider::class,
             ACLAuthServiceProvider::class,
+            IgnitionServiceProvider::class,
         ];
     }