This repository has been archived by the owner on Jan 29, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix the bug of #143, which was introduced in v2.2.0.
I have been able to reproduce the issue by pulling the
facade/ignition
composer requirement from the main composer file of a laravel project.laravel == v6.3.0
This makes sense as because the
laravel-acl
package now makes use of thefacade/ignition-contracts
, which has an interface that that is used to make the solution providers for the package available to ignition, unfortunately the interface is instantiated as a singleton from the main flare package, and without that it is not available to the normal laravel container/app.For this reason, the initial travis builds failed, and were bypassed under the basis that most apps using this would be using ignition already, although it is only included in
new
installs, and not ones that have continued using the whoops error pages and not chosen to upgrade to ignition error pages.I have now ensured that the tests for the ignition solutions are able to be instantiated, meaning that at least the package is installed and, will give users the ignition solutions, it may override there default error pages, but it does support back to laravel 5.5.
Should close #143.