Skip to content
This repository has been archived by the owner on Jan 29, 2024. It is now read-only.

Fix/issue 143 instatiate ignition #144

Merged

Conversation

ReeceM
Copy link
Contributor

@ReeceM ReeceM commented Oct 18, 2019

This is to fix the bug of #143, which was introduced in v2.2.0.

I have been able to reproduce the issue by pulling the facade/ignition composer requirement from the main composer file of a laravel project. laravel == v6.3.0

This makes sense as because the laravel-acl package now makes use of the facade/ignition-contracts, which has an interface that that is used to make the solution providers for the package available to ignition, unfortunately the interface is instantiated as a singleton from the main flare package, and without that it is not available to the normal laravel container/app.

For this reason, the initial travis builds failed, and were bypassed under the basis that most apps using this would be using ignition already, although it is only included in new installs, and not ones that have continued using the whoops error pages and not chosen to upgrade to ignition error pages.

I have now ensured that the tests for the ignition solutions are able to be instantiated, meaning that at least the package is installed and, will give users the ignition solutions, it may override there default error pages, but it does support back to laravel 5.5.

Should close #143.

this is for laravel versions without it already installed
@mateusjunges
Copy link
Owner

This solutions is exactly what i was thinking about. Hopefully it will solve #143.
About Laravel 5.5, don't worry. We dropped support for this version about a month ago, in 2.1.0 release.
Thanks!

@mateusjunges mateusjunges merged commit 9e06928 into mateusjunges:master Oct 18, 2019
@ReeceM
Copy link
Contributor Author

ReeceM commented Oct 18, 2019

Hi @mateusjunges, I just thought, maybe to move the facade/ignition requirement to the main one and not dev, as if someone runs with composer with the --no-dev flag it would bring the same issue back.

Or at least a note somewhere on a readme about that?

@mateusjunges
Copy link
Owner

I'll add a note somewhere in docs about that. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Facade\IgnitionContracts\SolutionProviderRepository not instantiable
2 participants