Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring lebesgue measure and integral #543

Merged
merged 5 commits into from
Feb 26, 2022
Merged

Conversation

CohenCyril
Copy link
Member

@CohenCyril CohenCyril commented Feb 17, 2022

Lebesgue measure and integral (was: "refactor of intervals")
CC @affeldt-aist

closes #371
closes #492

@affeldt-aist
Copy link
Member

affeldt-aist commented Feb 17, 2022

That's all fine with (modulo the changelog update :-/).

@affeldt-aist affeldt-aist mentioned this pull request Feb 25, 2022
2 tasks
@affeldt-aist affeldt-aist changed the base branch from lebesgue_measure to master February 25, 2022 10:50
@affeldt-aist affeldt-aist force-pushed the simplify_interval branch 5 times, most recently from 2642de7 to 9b75bab Compare February 25, 2022 17:14
Co-authored-by: Cyril Cohen <cyril.cohen@inria.fr>
@affeldt-aist
Copy link
Member

The errors are syntax errors with Coq 8.13 only.
I fixed some in lebesgue_measure.v (by adding parentheses to disambiguate the parsing of intervals) but didn't have time to fix the ones in `lebesgue_integral.v":

# File "./theories/lebesgue_integral.v", line 1428, characters 53-54:
# Error: Syntax error: 'nnsfun' 'of' expected after '[' (in [term]).

@affeldt-aist
Copy link
Member

The only errors are now "Nix CI for bundle" errors, so they are maybe not relevant.

@CohenCyril
Copy link
Member Author

The only errors are now "Nix CI for bundle" errors, so they are maybe not relevant.

@affeldt-aist I fixed something in boolp.v doc, added some (working) nix CI, and we should be good to go.

@affeldt-aist
Copy link
Member

Only one failure left:

Nix CI for bundle master / coq (pull_request_target)  Failing after 24s — coq

Checking presence of CI target coq

Run nb_dry_run=$(NIXPKGS_ALLOW_UNFREE=1 nix-build --no-out-link \
  nb_dry_run=$(NIXPKGS_ALLOW_UNFREE=1 nix-build --no-out-link \
     --argstr bundle "master" --argstr job "coq" \
     --dry-run 2>&1 > /dev/null)
  echo $nb_dry_run
  echo ::set-output name=status::$(echo $nb_dry_run | grep "built:" | sed "s/.*/built/")
  shell: /usr/bin/bash -e {0}
  env:
    tested_commit: dba57a6d631d8b2b199cc308d10a53590529fdea
    NIX_PATH: nixpkgs=channel:nixpkgs-unstable
Error: Process completed with exit code 1.

@CohenCyril CohenCyril changed the title Refactoring set_interval Refactoring lebesgue measure Feb 26, 2022
@CohenCyril CohenCyril changed the title Refactoring lebesgue measure Refactoring lebesgue measure and integral Feb 26, 2022
@CohenCyril
Copy link
Member Author

CohenCyril commented Feb 26, 2022

The CI errors will disapear after the merge

@CohenCyril CohenCyril merged commit 235eb04 into master Feb 26, 2022
This was referenced Feb 26, 2022
@CohenCyril CohenCyril deleted the simplify_interval branch March 2, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants