Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: forgotten parameters #138

Merged
merged 1 commit into from
Feb 14, 2021
Merged

Bugfix: forgotten parameters #138

merged 1 commit into from
Feb 14, 2021

Conversation

CohenCyril
Copy link
Member

  • factory local definitions were not taking parameters into account.
  • making sure factory/mixin arguments are always explicit.

@CohenCyril
Bugfix: forgotten parameters
9cd1f7a 
- factory local definitions were not taking parameters into account.
- making sure factory/mixin arguments are always explicit.
@CohenCyril
Copy link
Member Author

rebased

@CohenCyril CohenCyril merged commit ba49448 into master Feb 14, 2021
@CohenCyril CohenCyril deleted the fixfactoryfields branch February 14, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gares gares gares approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CohenCyril @gares