Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove retro compatibility aliases for permutations #418

Closed
gares opened this issue Nov 14, 2019 · 3 comments · Fixed by #468
Closed

remove retro compatibility aliases for permutations #418

gares opened this issue Nov 14, 2019 · 3 comments · Fixed by #468
Assignees
@ggonthier
Milestone
1.11+beta1

Comments

@gares
Copy link
Member

gares commented Nov 14, 2019 •
edited

Aliases were introduces in 1.9 and deprecated, so we can remove them in 1.11
@gares gares added this to the 1.11.0 milestone Nov 14, 2019
@gares gares changed the title remove comap alias for permutations remove retro compatibility aliases for permutations Nov 14, 2019
@gares
Copy link
Member Author

gares commented Mar 27, 2020

Ping @ggonthier it would be the right time to do this.

@gares
Copy link
Member Author

gares commented Mar 27, 2020 •
edited

For example I guess this one should be removed
https://github.com/math-comp/math-comp/blob/master/mathcomp/fingroup/perm.v#L581

@gares
Copy link
Member Author

gares commented Mar 27, 2020

Commit introducing the alias seems to be this one 5d7bd2e

ybertot added a commit to ybertot/math-comp that referenced this issue Mar 31, 2020
@ybertot
remove deprecated commands whose deprecation was introduced in releas…
d431b6b 
…e 1.9.0

fixes math-comp#418
ybertot added a commit to ybertot/math-comp that referenced this issue Mar 31, 2020
@ybertot
remove deprecated commands whose deprecation was introduced in releas…
a8c8fd1 
…e 1.9.0

fixes math-comp#418
@ybertot ybertot mentioned this issue Mar 31, 2020
Merged
1 task
@gares gares closed this as completed in #468 Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ggonthier ggonthier

Labels
None yet
Projects
None yet
Milestone
1.11+beta1
Development

Successfully merging a pull request may close this issue.

remove deprecated commands whose deprecation was introduced in 1.9.0 ybertot/math-comp
2 participants
@gares @ggonthier