Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated commands whose deprecation was introduced in 1.9.0 #468

Merged
merged 1 commit into from Apr 2, 2020

Conversation

ybertot
Copy link
Member

@ybertot ybertot commented Mar 31, 2020

fixes #418

Motivation for this change

Removing lemmas that were declared deprecated two releases before.

Things done/to do
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • [ ] added corresponding documentation in the headers
Automatic note to reviewers

Read this Checklist and make sure there is a milestone.

@ybertot ybertot added this to the 1.11.0 milestone Mar 31, 2020
@ybertot ybertot requested a review from gares March 31, 2020 15:59
@gares
Copy link
Member

gares commented Apr 1, 2020

@CohenCyril what do you think about the failure of finmap? I know we are close to integrate finmap in MC (1.12) but for MC 1.11 there seem not to be any working version. Do you want to make a release.

@ybertot
Copy link
Member Author

ybertot commented Apr 1, 2020

Failure of the ci-fourcolour-dev job is due to computation taking more than 1 hour, but recompilation on a dedicated machine succeeded.

@gares
Copy link
Member

gares commented Apr 1, 2020

Let me restart the job, since it usually takes 45 minutes

@gares
Copy link
Member

gares commented Apr 1, 2020

@CohenCyril told me that he shall make a pass on finmap & co to remove the use of deprecated aliases.

@CohenCyril could you write here what to do with this PR? Are you planning to update finmap soonish?

@ybertot
Copy link
Member Author

ybertot commented Apr 1, 2020

@CohenCyril For your information, I tried testing quickly with the following process to replace the offending lemmas, but this does not compile, apparently for a reason independent from the change in this PR.

git clone git@github.com:math-comp/finmap.git
cd finmap
for i in $(find . -name '*.v') ; do perl -npi.bak -e 's/eq_big_perm/permP/;' \
 -e 's/perm_eq_mem/perm_mem/; s/perm_eqP/permP/; s/perm_eq_size/perm_size/;' \
 -e 's/perm_eq_small/perm_small_eq/; s/perm_eq_sym/perm_sym/;' \
 -e 's/perm_eq_trans/perm_trans/; s/perm_eq_uniq/perm_uniq/;' \
 -e 's/uniq_perm_eq/uniq_perm/' $i ; done

The offending line is at 2277 in finmap.v

@CohenCyril
Copy link
Member

The culprit is

s/eq_big_perm/permP/

which should be s/eq_big_perm/perm_big/

@CohenCyril
Copy link
Member

@CohenCyril told me that he shall make a pass on finmap & co to remove the use of deprecated aliases.

@CohenCyril could you write here what to do with this PR? Are you planning to update finmap soonish?

done, all lights are green now

@gares gares self-assigned this Apr 2, 2020
@gares gares merged commit 0ce6013 into math-comp:master Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove retro compatibility aliases for permutations
3 participants