Add more front end code standards #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
eito-fis,
ghislaineguerin,
kgodey,
mathemancer,
pavish and
silentninja
and removed request for
a team
seancolsen
removed request for
eito-fis,
ghislaineguerin,
kgodey,
mathemancer and
silentninja
|
@pavish Can you review this? |
seancolsen
commented
Jan 19, 2022
Comment on lines
+233
to
+237
|
|
||
| - Prefer `interface` when possible. | ||
| - Use `type` when necessary. | ||
|
|
There was a problem hiding this comment.
@pavish the "type vs interface" section is some content that we haven't discussed before, but from reading your code I've deduced that we're on the same page about this (which is also the direction that I think the large TS community is going).
|
@kgodey no action needed from you here, but I just wanted to highlight this new content as a direct response to your suggestion of increasing our ongoing documentation efforts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.