-
-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Focus state being reset by browser in pagination component #1040
Comments
@pavish @seancolsen hi, can i work on this issue? |
Go ahead @priyang12, thanks! |
@kgodey hi i think i have resolved this issue here is a Screen.Recording.2022-03-22.at.1.58.00.PM.movclip of it . I have changed the color to red for better check but i have removed it later. |
It sounds like you're making some progress. That's great! Have you opened a PR with your work? I don't see one. Make sure to link your PR to this ticket by placing the text |
@seancolsen I have one PR 1200 open so I can't make another one. should I make a new branch and make a pull request? |
@priyang12 Yes, please create new branches for each of the issue you're working on and open separate PRs. |
Pagination component improvement:
Originally posted by @pavish in #963 (comment)
Issue:
We should be resolving this by manually setting focus on the current active page when ellipsis/arrow disappears. In the above example, when we click on the ellipsis and page number is changed to 2, we should be doing
element.focus()
to focus the button with page number 2. We can add adata-page
attribute to help query the element.The text was updated successfully, but these errors were encountered: