Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add E2E test for trying to to rename a table to the name of another table #1125

Closed
Tracked by #1122
seancolsen opened this issue Mar 2, 2022 · 2 comments · Fixed by #1160
Closed
Tracked by #1122

Add E2E test for trying to to rename a table to the name of another table #1125

seancolsen opened this issue Mar 2, 2022 · 2 comments · Fixed by #1160
Assignees
@ManishShah120
Labels
good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Milestone
[06.1] 2022-03 im...

Comments

@seancolsen
Copy link
Contributor

Context

See #1122 for more info and instructions on writing E2E tests.

This test

Write an E2E test which asserts that "trying to to rename a table to the name of another table" works as-expected. Here's a visual demo of what the test should do:

Peek 2022-03-02 16-45

Tips

  • Assert that the error message is shown and that the save button is disabled
@seancolsen seancolsen added ready Ready for implementation type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this labels Mar 2, 2022
@seancolsen seancolsen added this to the [12.1] 2022-05 improvements milestone Mar 2, 2022
@seancolsen seancolsen mentioned this issue Mar 2, 2022
Closed
9 tasks
@ManishShah120
Copy link
Contributor

ManishShah120 commented Mar 11, 2022 •
edited
Loading

I would like to take up this issue, working on it.

@seancolsen
Copy link
Contributor Author

Thanks @ManishShah120 I've assigned it to you.

ManishShah120 added a commit to ManishShah120/mathesar that referenced this issue Mar 11, 2022
@ManishShah120
closes mathesar-foundation#1125
84f2571 
Added e2e tests for renaming a table name
with the existing table names
@ManishShah120 ManishShah120 mentioned this issue Mar 11, 2022
Merged
7 tasks
@kgodey kgodey added status: started and removed ready Ready for implementation labels Mar 11, 2022
@kgodey kgodey modified the milestones: [12.1] 2022-05 improvements, [06.1] 2022-03 improvements Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ManishShah120 ManishShah120

Labels
good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Projects
No open projects
[NO LONGER USED] Mathesar work tracker
Archived in project
Milestone
[06.1] 2022-03 improvements
Development

Successfully merging a pull request may close this issue.

Add E2E test for trying to to rename a table to the name of another table ManishShah120/mathesar
3 participants
@seancolsen @kgodey @ManishShah120