Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E2E test for moving the selected cell with arrow keys #1130

Closed
Tracked by #1122
seancolsen opened this issue Mar 2, 2022 · 7 comments · Fixed by #1178
Closed
Tracked by #1122

Add E2E test for moving the selected cell with arrow keys #1130

seancolsen opened this issue Mar 2, 2022 · 7 comments · Fixed by #1178
Assignees
Labels
good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory

Comments

@seancolsen
Copy link
Contributor

Context

See #1122 for more info and instructions on writing E2E tests.

This test

Write an E2E test which asserts that "moving the selected cell with arrow keys" works as-expected. Here's a visual demo of what the test should do:

Peek 2022-03-02 17-07

@seancolsen seancolsen added ready Ready for implementation type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this labels Mar 2, 2022
@seancolsen seancolsen added this to the [12.1] 2022-05 improvements milestone Mar 2, 2022
@ManishShah120
Copy link
Contributor

I would love to take up this issue. 😃

@kgodey
Copy link
Contributor

kgodey commented Mar 12, 2022

@ManishShah120 I assigned you #1128, please work on that first (we have a limited supply of good first issue tickets and would like to spread them across different contributors).

@priyang12
Copy link
Contributor

hi, can I work on this issue if no one is working on it? @seancolsen @kgodey

@kgodey kgodey added status: started and removed ready Ready for implementation labels Mar 14, 2022
@kgodey
Copy link
Contributor

kgodey commented Mar 14, 2022

Go ahead @priyang12!

@priyang12
Copy link
Contributor

priyang12 commented Mar 15, 2022

@kgodey hi, I am having an issue Inspecting the page during a test. I followed readme Page and when i run the
docker exec mathesar_service pytest --headed --no-cov -k test_page_shows_welcome_text Command
I got this error

startup-window
E       <launched> pid=323
E       [pid=323][err] [323:323:0315/105628.185292:FATAL:ozone_platform_x11.cc(231)] Check failed: x11::Connection::Get()->Ready(). Missing X server or $DISPLAY

I am using a mac machine and I installed XQuartz and change the security permission has the error has something to do with that??

@silentninja
Copy link
Contributor

Have you tried setting the ip for the $DISPLAY environment variable?

(For Mac OS only): Also change DISPLAY=${DISPLAY} to DISPLAY=${YOUR_IP}:0, e.g. DISPLAY=192.168.29.198:0
For Mac OS, run xhost +${YOUR_IP} -- e.g. xhost +192.168.29.198

@pavish
Copy link
Member

pavish commented Mar 15, 2022

@priyang12

Please make sure all the steps are followed. You might have missed a few:

  1. Identify your host's ip address. You can run ifconfig to obtain it. Assume your ip is 192.168.29.194
  2. Modify docker-compose.yml. Change DISPLAY=${DISPLAY} to DISPLAY={your ip}:0 eg., DISPLAY=192.168.29.194:0. Notice that you have to add :0 after your ip.
  3. Run xhost +{your ip} on your host. Eg., xhost +192.168.29.194

After this, try running the tests in headed mode again

seancolsen added a commit that referenced this issue Mar 18, 2022
E2E Test issue #1130 For moving the selected cell with arrow keys
@kgodey kgodey modified the milestones: [12.1] 2022-05 improvements, [06.1] 2022-03 improvements Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

6 participants