Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend implementation for Duration Mathesar type #261

Closed
Tracked by #251
kgodey opened this issue Jun 14, 2021 · 1 comment · Fixed by #1350
Closed
Tracked by #251

Frontend implementation for Duration Mathesar type #261

kgodey opened this issue Jun 14, 2021 · 1 comment · Fixed by #1350
Assignees
Labels
type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory

Comments

@kgodey
Copy link
Contributor

kgodey commented Jun 14, 2021

Requirements

Users should be able to:

  • view data in columns that have the Duration Mathesar type
  • change data type to and from the associated INTERVAL DB type
  • view, set, and change data type options related to the Duration data types
  • filter data by Duration-specific filtering options
  • group data by Duration-specific grouping options
  • use display options to view data in Duration type columns
    • Duration should be formatted according to the format in the display option

Update:

DB Type Mapping

There is only DB type - INTERVAL so no special mapping rules are necessary.

Implementation

Design

Backend

  • /api/v0/tables/ lists the name and DB type of each columns
  • /api/v0/tables/<id/columns/ lists column information in more detail
  • /api/v0/databases/<id>/types/ maps Mathesar types to DB types and provides a list of filtering and grouping options per-type.
    • These should be used to populate the filter and grouping options dynamically.
  • Updates to column types and type options should happen via PATCH requests to /api/v0/tables/<id>/columns/<id>/. These updates include
    • Changes to the data type (type)
    • Changes to the display options (display_options)

Additional Context

@kgodey kgodey added type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory needs: unblocking Blocked by other work status: detail needed labels Jun 14, 2021
@kgodey kgodey added this to the 8. Initial Data Types milestone Jun 14, 2021
@kgodey kgodey removed the needs: unblocking Blocked by other work label Jun 18, 2021
@kgodey kgodey changed the title Frontend implementation for duration data type Frontend implementation for Duration Mathesar type Sep 13, 2021
@kgodey kgodey added needs: unblocking Blocked by other work and removed status: draft labels Sep 13, 2021
@kgodey
Copy link
Contributor Author

kgodey commented Mar 1, 2022

Marking this as ready since filtering and grouping have been moved to other issues and remaining backend work is done.

@kgodey kgodey added ready Ready for implementation and removed needs: unblocking Blocked by other work labels Mar 1, 2022
@pavish pavish self-assigned this Apr 18, 2022
@pavish pavish added status: started and removed ready Ready for implementation labels May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants