Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend implementation for type specific grouping options #1073

Closed
pavish opened this issue Feb 15, 2022 · 3 comments
Closed

Frontend implementation for type specific grouping options #1073

pavish opened this issue Feb 15, 2022 · 3 comments
Labels
needs: unblocking Blocked by other work type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Milestone

Comments

@pavish
Copy link
Member

pavish commented Feb 15, 2022

Problem

Users should be able to view and apply type specific grouping for each column.

Proposed solution

We have a set of backend tickets to implement grouping options for each type. A few:

The backend would provide the set of possible grouping options as mentioned in the above tickets.

The frontend should make use of those options and display them accordingly, and allow the user to group records using them.

Additional context

Blocked by:

@pavish
Copy link
Member Author

pavish commented Sep 5, 2022

@kgodey Do we need to implement additional grouping options for the live demo or the public release?

Currently, we have distinct grouping for all types, and types such as email, uri, date/time etc., have additional preproc functions.

I think ranged grouping and more preproc functions for types like duration can be safely deferred, and we could move this issue to the 2023 or later milestone.

@kgodey
Copy link
Contributor

kgodey commented Sep 6, 2022

@pavish Can you make a list of features that you're proposing deferring? I'm not sure what this means:

preproc functions for types like duration

Even better than that would be to close this issue and make separate issues for each grouping type that was on our plan but hasn't been implemented yet. We can then prioritize each separately.

@pavish
Copy link
Member Author

pavish commented Mar 15, 2023

I'm marking this issue as closed since we have specific grouping per type implemented already.

Types that do not have custom grouping options are tracked separately. The tickets are mentioned in the description.

The frontend currently stubs grouping options instead of receiving it from the backend, but that is out-of-scope of this issue and is related to #1983

@pavish pavish closed this as completed Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: unblocking Blocked by other work type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Projects
No open projects
Development

No branches or pull requests

2 participants