Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement filtering options for the money type #418

Closed
Tracked by #249
kgodey opened this issue Jul 17, 2021 · 3 comments · Fixed by #1090
Closed
Tracked by #249

Implement filtering options for the money type #418

kgodey opened this issue Jul 17, 2021 · 3 comments · Fixed by #1090
Assignees
Labels
type: enhancement New feature or request work: backend Related to Python, Django, and simple SQL

Comments

@kgodey
Copy link
Contributor

kgodey commented Jul 17, 2021

Problem

We need to ensure that records that include columns of all Money types support the same filters as Number types via the API. Please see #385 for the full list.

We should be able to reuse the implementation for Number types here.

This involves:

  • Implementing the filters in the backend
  • Updating the /api/v0/databases/<id>/types/ endpoint to store available filters on Number types.
    • Filter information should include the number of parameters needing to be passed in (e.g. between needs 2 parameters, is empty needs 0)

Additional context

@kgodey kgodey added this to the 07. Initial Data Types milestone Jul 17, 2021
@kgodey kgodey added needs: unblocking Blocked by other work type: enhancement New feature or request work: backend Related to Python, Django, and simple SQL work: database labels Jul 17, 2021
@silentninja silentninja added ready Ready for implementation and removed needs: unblocking Blocked by other work labels Feb 14, 2022
@kgodey kgodey changed the title Implement filtering options for the Mathesar money type Implement filtering options for the money type Feb 14, 2022
@dmos62
Copy link
Contributor

dmos62 commented Feb 21, 2022

Closing, since it was decided not to use a custom money type.

@silentninja
Copy link
Contributor

We still need filters for Postgres Money Type I think

@kgodey
Copy link
Contributor Author

kgodey commented Feb 21, 2022

We still need filters for Postgres Money Type I think

Yes, we do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request work: backend Related to Python, Django, and simple SQL
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants