Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle MONEY data type in the backend. #420

Closed
Tracked by #249
kgodey opened this issue Jul 17, 2021 · 2 comments · Fixed by #1060
Closed
Tracked by #249

Handle MONEY data type in the backend. #420

kgodey opened this issue Jul 17, 2021 · 2 comments · Fixed by #1060
Assignees
Labels
type: enhancement New feature or request work: backend Related to Python, Django, and simple SQL

Comments

@kgodey
Copy link
Contributor

kgodey commented Jul 17, 2021

This issue is to ensure that Mathesar can handle the Postgres MONEY data type.

As part of this issue, we need to ensure that:

  • Users can use the API to change a column to MONEY if it's possible to do so.
  • Automatic type inference during file import suggests MONEY when the MATHESAR_MONEY type is not installed and the currency detected matches the Postgres lc_monetary setting.

Additional Context

@kgodey kgodey added work: backend Related to Python, Django, and simple SQL work: database ready Ready for implementation type: enhancement New feature or request needs: unblocking Blocked by other work and removed ready Ready for implementation labels Jul 17, 2021
@kgodey kgodey added this to the 07. Initial Data Types milestone Jul 17, 2021
@mathemancer
Copy link
Contributor

To double-check my understanding, we should expect a currency symbol to infer a column should be a MONEY type, correct?

@kgodey
Copy link
Contributor Author

kgodey commented Jul 19, 2021

@mathemancer Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request work: backend Related to Python, Django, and simple SQL
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants