-
-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UI to filter on a value being NULL #789
Comments
@seancolsen The filters are meant to be dynamic i.e anything related to column types is meant to be dynamic. For eg., for the type Number, the server should provide what kind of filters are applicable for number, what input type should be shown within the table, the grouping options we should allow for it, the icons required for it etc., This way we can easily add and remove types without having to update any frontend code, making it possible to provide data types as plugins. I'm not sure how well we'd be able to get it done for the alpha release. But it's part of the frontend stories you could see in https://github.com/centerofci/mathesar/milestone/11 and an additional issue that tracks some of it: #661 This is to say that the "Equals" and "Not Equals" are both temporary conditions that were hardcoded on the frontend, and they would be eventually provided by the server, which will include isNull. @kgodey I assume this is our plan for the alpha. Please let us know if you think it would be better to hardcode type specific properties on the frontend instead. |
@kgodey Thanks. Sounds good to me. |
@seancolsen I think this can wait until type configuration is complete as part of #500. |
Closing this issue since it's no longer relevant. The filters are based on each column type and they contain the filter |
Problem
User has no way to add a filter condition specifying that a value should be NULL.
Proposed solution
In addition to "Equals" and "Not Equals", we should have an "Is NULL" option when setting a filter condition.
The text was updated successfully, but these errors were encountered: