-
-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set default value for columns #1320
Conversation
…set_column_default_value
…set_column_default_value
…set_column_default_value
…set_column_default_value
… type defintions. Moves types from component module to ts files. Reasoning: Unit tests fail when types are imported in a ts file from a component directly. See sveltejs/svelte#5817.
…set_column_default_value
Codecov Report
@@ Coverage Diff @@
## master #1320 +/- ##
=======================================
Coverage 93.65% 93.65%
=======================================
Files 114 114
Lines 4431 4431
=======================================
Hits 4150 4150
Misses 281 281
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've only given the diff a cursory skim, but I didn't notice any red flags. And I played with the new functionality and it looks good. Exciting to have this feature!
@@ -209,7 +205,7 @@ const displayForm: AbstractTypeConfigForm = { | |||
}, | |||
format: { | |||
type: 'string', | |||
enum: ['none', 'af', 'ar-DZ', 'bg', 'bn', 'de-CH'], | |||
enum: ['none', 'english', 'german', 'french', 'hindi', 'swiss'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes also exist in #1229, where @silentninja has been planning to add the corresponding back-end changes to handle this new schema. I think for the sake of speed we ought to just merge them into master
within this PR here, close #1229, and handle the necessary back-end changes independently.
|
||
/** | ||
* Classes to apply to the trigger button (the dropdown button). | ||
*/ | ||
export let triggerClass = ''; | ||
export let triggerClass: DefinedProps['triggerClass'] = ''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice this pattern throughout your changes in this PR.
What's the benefit of writing
export let triggerClass: DefinedProps['triggerClass'] = '';
instead of the following?
export let triggerClass = '';
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No additional benefit other than consistency. Since we are explicitly exporting an interface in the component, it makes sense to mention the types to all the props from that interface.
Fixes #500
This PR:
Screen.Recording.2022-04-28.at.2.48.06.AM.mov
Tips for reviewers
/src/components/cell/
and/src/sections/table-view/header/header-cell/abstract-type-configuration/
directories.Note: The E2E test is commented out since it depends on #1276 to be fixed.
I intend to create a few UX tickets to sort out in the styling and UX improvements milestone
Checklist
Update index.md
).master
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin