Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UX for new row with NOT NULL constraint #1385

Merged
merged 9 commits into from
Jun 3, 2022

Conversation

seancolsen
Copy link
Contributor

Fixes #775
Fixes #1362

Demo

https://www.loom.com/share/b8da99a10eec4719b71c4ade93102c85

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the master branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@seancolsen seancolsen requested review from a team and pavish and removed request for a team May 18, 2022 17:57
@codecov-commenter

This comment was marked as off-topic.

@seancolsen seancolsen added the pr-status: review A PR awaiting review label May 18, 2022
@seancolsen
Copy link
Contributor Author

Ok, the E2E test failure here is actually a good catch. Thanks, Playwright! I need to spend some more time on this, so I'm sending it back to draft state.

@seancolsen seancolsen marked this pull request as draft May 19, 2022 21:07
@seancolsen seancolsen removed the pr-status: review A PR awaiting review label May 19, 2022
@seancolsen
Copy link
Contributor Author

I pushed another commit to fix the bug that the E2E test caught. It brought to light an interesting edge case which warrants its own demo. Please also watch this video when reviewing:

https://www.loom.com/share/fd29aae20abf4877bb7f62e433cfaf8d

@seancolsen seancolsen marked this pull request as ready for review May 20, 2022 16:24
@seancolsen seancolsen added the pr-status: review A PR awaiting review label May 20, 2022
Copy link
Member

@pavish pavish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seancolsen Nice work on this!

I tested a few scenarios and the UX looks good to me. There are some scenarios that are okay with me but I'm not sure on how the target users might perceive it.

For eg., For checkbox, when DEFAULT is displayed and the user clicks on the cell, it toggles the value and the checkbox is then displayed. This seems reasonable to me, but this is one of the areas where we should try to get the user's opinions when possible after the alpha.

@pavish pavish enabled auto-merge June 3, 2022 06:12
@pavish pavish merged commit 6b2e21b into master Jun 3, 2022
@pavish pavish deleted the 775_new_row_with_not_null branch June 3, 2022 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
No open projects
3 participants