Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default polymorphic serializer #1392

Merged
merged 5 commits into from
May 31, 2022
Merged

Conversation

silentninja
Copy link
Contributor

@silentninja silentninja commented May 23, 2022

Related to #944

Adds support for default serializer to mathesar.api.serializers.shared_serializers.ReadWritePolymorphicSerializerMappingMixin.

Default serializer is needed to provide a common set of fields like show_fk_preview for all supported column types without having to declare a serializer for each column type.

The PR also adds show_fk_preview field as a display option for all the column types.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the master branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@silentninja silentninja requested review from a team and dmos62 and removed request for a team May 23, 2022 14:48
@kgodey kgodey added the pr-status: review A PR awaiting review label May 23, 2022
@dmos62
Copy link
Contributor

dmos62 commented May 25, 2022

@silentninja looks good; can you resolve merge conflicts?

@dmos62 dmos62 added pr-status: revision A PR awaiting follow-up work from its author after review and removed pr-status: review A PR awaiting review labels May 25, 2022
@silentninja silentninja merged commit 11a0b77 into master May 31, 2022
@silentninja silentninja deleted the default-polymorphic-serializer branch May 31, 2022 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: revision A PR awaiting follow-up work from its author after review
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants