Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefix /db/ to database route and subroutes #2791

Merged
merged 2 commits into from Apr 7, 2023

Conversation

pavish
Copy link
Member

@pavish pavish commented Apr 6, 2023

Fixes #2402

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@pavish pavish requested a review from seancolsen April 6, 2023 19:48
@pavish pavish added the pr-status: review A PR awaiting review label Apr 6, 2023
@pavish pavish added this to the v0.1.2 milestone Apr 6, 2023
Copy link
Contributor

@seancolsen seancolsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Works well.

@seancolsen seancolsen added this pull request to the merge queue Apr 7, 2023
@seancolsen
Copy link
Contributor

@pavish I think this change is worth calling out specifically in the release notes because it will break any hyperlinks that people might have outside Mathesar which refer to Mathesar tables etc. Not a huge problem at our early stage, but it's the kind of thing that we'll need to be increasingly careful about as more people rely on Mathesar.

Merged via the queue into develop with commit a75e5dc Apr 7, 2023
21 checks passed
@seancolsen seancolsen deleted the 2402-routing-changes branch April 7, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Modify page routing to allow for any database name
2 participants