Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefix /db/ to database route and subroutes #2791

Merged
merged 2 commits into from
Apr 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions mathesar/urls.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,10 @@
path('administration/users/', views.admin_home, name='admin_users_home'),
path('administration/users/<user_id>/', views.admin_home, name='admin_users_edit'),
path('administration/update/', views.admin_home, name='admin_update'),
path('<db_name>/', views.schemas, name='schemas'),
path('db/', views.home, name='db_home'),
path('db/<db_name>/', views.schemas, name='schemas'),
re_path(
r'^(?P<db_name>\w+)/(?P<schema_id>\w+)/',
r'^db/(?P<db_name>\w+)/(?P<schema_id>\w+)/',
views.schema_home,
name='schema_home'
),
Expand Down
2 changes: 1 addition & 1 deletion mathesar_ui/src/routes/RootRoute.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
</Route>
{/if}

<Route path="/:databaseName/*" let:meta firstmatch>
<Route path="/db/:databaseName/*" let:meta firstmatch>
<DatabaseRoute databaseName={meta.params.databaseName} />
</Route>

Expand Down
27 changes: 16 additions & 11 deletions mathesar_ui/src/routes/urls.ts
Original file line number Diff line number Diff line change
@@ -1,72 +1,75 @@
export function getDatabasePageUrl(databaseName: string): string {
return `/${databaseName}/`;
return `/db/${databaseName}/`;
}

export function getSchemaPageUrl(
databaseName: string,
schemaId: number,
): string {
return `/${databaseName}/${schemaId}/`;
return `${getDatabasePageUrl(databaseName)}${schemaId}/`;
}

export function getSchemaPageTablesSectionUrl(
databaseName: string,
schemaId: number,
): string {
return `/${databaseName}/${schemaId}/tables/`;
return `${getSchemaPageUrl(databaseName, schemaId)}tables/`;
}

export function getSchemaPageExplorationsSectionUrl(
databaseName: string,
schemaId: number,
): string {
return `/${databaseName}/${schemaId}/explorations/`;
return `${getSchemaPageUrl(databaseName, schemaId)}explorations/`;
}

export function getImportPageUrl(
databaseName: string,
schemaId: number,
): string {
return `/${databaseName}/${schemaId}/import/`;
return `${getSchemaPageUrl(databaseName, schemaId)}import/`;
}

export function getImportPreviewPageUrl(
databaseName: string,
schemaId: number,
previewTableId: number,
): string {
return `/${databaseName}/${schemaId}/import/${previewTableId}/`;
return `${getImportPageUrl(databaseName, schemaId)}${previewTableId}/`;
}

export function getDataExplorerPageUrl(
databaseName: string,
schemaId: number,
): string {
return `/${databaseName}/${schemaId}/data-explorer/`;
return `${getSchemaPageUrl(databaseName, schemaId)}data-explorer/`;
}

export function getExplorationPageUrl(
databaseName: string,
schemaId: number,
queryId: number,
): string {
return `/${databaseName}/${schemaId}/explorations/${queryId}/`;
return `${getSchemaPageExplorationsSectionUrl(
databaseName,
schemaId,
)}${queryId}/`;
}

export function getExplorationEditorPageUrl(
databaseName: string,
schemaId: number,
queryId: number,
): string {
return `/${databaseName}/${schemaId}/explorations/${queryId}/edit/`;
return `${getExplorationPageUrl(databaseName, schemaId, queryId)}edit/`;
}

export function getTablePageUrl(
databaseName: string,
schemaId: number,
tableId: number,
): string {
return `/${databaseName}/${schemaId}/tables/${tableId}/`;
return `${getSchemaPageTablesSectionUrl(databaseName, schemaId)}${tableId}/`;
}

export function getRecordPageUrl(
Expand All @@ -75,7 +78,9 @@ export function getRecordPageUrl(
tableId: number,
recordId: unknown,
): string {
return `/${databaseName}/${schemaId}/tables/${tableId}/${String(recordId)}`;
return `${getTablePageUrl(databaseName, schemaId, tableId)}${String(
recordId,
)}`;
}

export const USER_PROFILE_URL = '/profile/';
Expand Down