Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cell value for fk referenced columns #3239

Merged
merged 8 commits into from Oct 24, 2023
Merged

Use cell value for fk referenced columns #3239

merged 8 commits into from Oct 24, 2023

Conversation

Anish9901
Copy link
Member

@Anish9901 Anish9901 commented Oct 10, 2023

Fixes #3232

Technical details

For a column with a FK constraint, the backend expects the value of the cell of the referenced column instead of the the row id of the row in which the cell is present in. This PR implements the same.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Anish9901 Anish9901 requested a review from pavish October 10, 2023 15:18
@kgodey kgodey modified the milestones: Backlog, v0.1.5 Oct 10, 2023
@Anish9901 Anish9901 added the pr-status: review A PR awaiting review label Oct 11, 2023
Copy link
Member

@pavish pavish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anish9901 Looks good!

I added f1c65b5 to fix some of the types. columnFabric needs to be of the CellColumnFabric type and not the extended ProcessedColumn type because the parent CellFabric component specifies the base type.

@pavish pavish added this pull request to the merge queue Oct 24, 2023
Merged via the queue into develop with commit 6e11407 Oct 24, 2023
11 checks passed
@pavish pavish deleted the fk_as_value branch October 24, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

BUG: UI SQL construction does not respect FK reference. Assumes reference is to PK column.
3 participants