Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display more accurate infoAlertText on foreign key columns #3260

Conversation

ejenk0
Copy link
Contributor

@ejenk0 ejenk0 commented Oct 25, 2023

Update the displayed text to be more accurate, not mentioning primary keys specifically.

Fixes #3247

Technical details

Screenshots
Next InfoBox for foreign key columns:
Screenshot 2023-10-26 at 8 26 27 am

/cc @seancolsen @kgodey

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

ejenk0 and others added 2 commits October 26, 2023 08:24
Update the displayed text to be more accurate, not mentioning primary
keys specifically.
@seancolsen seancolsen added this pull request to the merge queue Oct 25, 2023
Merged via the queue into mathesar-foundation:develop with commit 39ea29a Oct 25, 2023
7 checks passed
@ejenk0 ejenk0 deleted the issue-3247-inaccurate-info-for-foreign-key-column-referencing-unique-column branch October 26, 2023 00:28
@ejenk0
Copy link
Contributor Author

ejenk0 commented Oct 26, 2023

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Inaccurate info for a foreign key column referencing a non-pk column
2 participants