New DB connection form

[seancolsen]

Fixes #3311

Discrepancies from spec

This PR follows the spec except in these places:

Connection nickname displays in connection selector

I decided to display the connection nickname to the connection selector dropdown:

Spec	PR

This makes the options easier to read and has the added benefit of giving us a easy way to distinguish the internal connection from the user database connections.

"Learn more" docs hyperlinks missing

The spec has some "Learn more" hyperlinks inside help text which should point to docs pages. I'd like to add those in a subsequent PR, potentially even in a subsequent release. I'll open an issue for it after we merge this PR and we can discuss priority at that point.

Checklist

• My pull request has a descriptive title (not a vague title like Update index.md).
• My pull request targets the develop branch of the repository
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[seancolsen]

@ghislaineguerin @kgodey @pavish @mathemancer since (I think) you were all involved in reviewing the spec I want to give you a heads up about a minor design change that I improvised within this PR. See the "Connection nickname displays in connection selector" section above and let me know if you have any concerns.

[seancolsen]

@pavish this PR is ready for review but is still marked draft due to being stacked on top of #3348. Since it's rather large (and also high priority), I'm assigning you to review it now so that we can hopefully get a head start. Make sure not to merge it until #3348 is merged though.

[kgodey]

See the "Connection nickname displays in connection selector" section above and let me know if you have any concerns.

No concerns.

[pavish]

"Connection nickname displays in connection selector"

No concerns from me.

[ghislaineguerin]

@seancolsen looks good. no concerns

[seancolsen]

@pavish this is ready for further review now.

[pavish]

Looks good!