Removed the 'group' suffix in Data Explorer

[ishir21]

Fixes #2333

When Summarizing in Data Explorer , the grouping column gets a default group suffix appended, I have removed the suffix as discussed in the issue.
Technical details

Screenshots

Checklist

• My pull request has a descriptive title (not a vague title like Update index.md).
• My pull request targets the develop branch of the repository
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no
  visible errors.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[sangramrajekakade]

Unsubscribe

…

On Mon, Dec 18, 2023 at 10:46 AM Ishir Agrawal ***@***.***> wrote: Fixes #[2333] When Summarizing in Data Explorer , the grouping column gets a default group suffix appended, I have removed the suffix as discussed in the issue. *Technical details* *Screenshots* Checklist - My pull request has a descriptive title (not a vague title like Update index.md). - My pull request targets the develop branch of the repository - My commit messages follow best practices <https://gist.github.com/robertpainsi/b632364184e70900af4ab688decf6f53> . - My code follows the established code style of the repository. - I added tests for the changes I made (if applicable). - I added or updated documentation (if applicable). - I tried running the project locally and verified that there are no visible errors. Developer Certificate of Origin Developer Certificate of Origin Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ------------------------------ You can view, comment on, or merge this pull request online at: #3357 Commit Summary - 7b9368e <7b9368e> Removed the 'group' suffix in Data Explorer File Changes (1 file <https://github.com/mathesar-foundation/mathesar/pull/3357/files>) - *M* mathesar/models/query.py <https://github.com/mathesar-foundation/mathesar/pull/3357/files#diff-7c20daec2eb3fa4c134c0436f8e25ffddce46777de6a23364aef737fdfe4df77> (3) Patch Links: - https://github.com/mathesar-foundation/mathesar/pull/3357.patch - https://github.com/mathesar-foundation/mathesar/pull/3357.diff — Reply to this email directly, view it on GitHub <#3357>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACATU5G5LOT33IPP6J77GDLYJ7GSJAVCNFSM6AAAAABAY6HPEKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA2DKNZVHAZDMNI> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

-- Thanks & Regards, Sangram Kakade <http://www.sangramkakade.com> Python/Django Developer Mob.No. 9975159162

[ishir21]

@Anish9901 any updates?

[Anish9901]

Hey @ishir21, sorry that it's taking this long for me to review your PR, actually we are in the middle of making a release and therefore, haven't got to taking a look at your PR yet. I'll go through it as soon as possible.

[seancolsen]

@Anish9901 can you try to move this along?

[kgodey]

I put this in 0.1.7 so it's clearer that this should be prioritized.

[Anish9901]

@ishir21 This if statement is unnecessary and can be removed, you can directly return input_alias_display_name.

[kgodey]

Since this is in the next release and it's been open for so long, @Anish9901 please make the necessary changes yourself if you don't hear from @ishir21 by mid-next week.

[ishir21]

@Anish9901 I have made the changes

[Anish9901]

@ishir21, I see that some of the Python tests in the CI are failing due to the changes made in the PR, Can you fix them so that they match the intended behavior?

[Anish9901]

Thanks for your contribution @ishir21! I pushed a commit(fcfd190) to fix the breaking tests, so, that we could include this PR in this month's release.