New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable i18n #3486
Enable i18n #3486
Conversation
@ghislaineguerin @kgodey I've assigned you to review this PR to take a call on the UX considerations mentioned above for the language switcher that is visible on the login page, which was added as part of this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this out and it looks like it works great. Code changes look straightforward.
私たちのアプリケーションが日本語で表示されるのは本当にエキサイティングです!
...It's really exciting to see our application in Japanese!
@pavish I would just merge this as-is and make a separate GitHub issue for the UX concerns you've listed here, I agree that the experience could be improved but I don't think it's bad enough to block release / we can fix in the next release. |
Sounds good. |
This PR Enables switching languages
Tasks:
Add docs for building po files in Wiki(added in GH workflow to create draft release with built static files #3489)Show language switcher dropdown in password change page and superuser creation page?(Out of scope for this PR)UX considerations
Checklist
Update index.md
).develop
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin