Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made release notes script portable. #3529

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Made release notes script portable. #3529

merged 4 commits into from
Apr 11, 2024

Conversation

kgodey
Copy link
Contributor

@kgodey kgodey commented Apr 11, 2024

Fixes #3515

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@kgodey kgodey added this to the v0.1.7 milestone Apr 11, 2024
@kgodey kgodey added the pr-status: review A PR awaiting review label Apr 11, 2024
@kgodey
Copy link
Contributor Author

kgodey commented Apr 11, 2024

This was working for me after these changes. Assigned to @Anish9901 to make sure it runs on a Mac and to @seancolsen to make sure it still runs on Linux and does what it supposed to.

@seancolsen seancolsen removed their assignment Apr 11, 2024
@seancolsen
Copy link
Contributor

I pushed some changes to further improve this so that it would work for me.

@Anish9901 perhaps you could test on both Mac OS and Linux?

@Anish9901
Copy link
Member

Anish9901 commented Apr 11, 2024

Looks good to me @seancolsen & @kgodey. I ran the script on Mac OS and Linux and upon diffing the outputs, I found no changes between them. On Mac OS, I did get a warning, but, I am fine with ignoring it.

Here is the exact warning that I was getting if you're curious:

<string>:3: DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.now(datetime.UTC).

@Anish9901 Anish9901 added this pull request to the merge queue Apr 11, 2024
Merged via the queue into develop with commit 05f6fe2 Apr 11, 2024
34 checks passed
@Anish9901 Anish9901 deleted the fix_release_script branch April 11, 2024 19:17
kgodey added a commit that referenced this pull request Apr 11, 2024
github-merge-queue bot pushed a commit that referenced this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make release notes helper script more portable
3 participants