Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up automatic code-coverage report for backend #817

Closed

Conversation

VFermat
Copy link
Contributor

@VFermat VFermat commented Nov 11, 2021

Fixes #603

Generates automatic Code Coverage Report using pytest-cov and Coverage

Technical details
Alters the pytest workflow to generate a Coverage report using xml and send it to Coverage.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the master branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Vitor Eller

@VFermat VFermat marked this pull request as ready for review November 18, 2021 00:01
@VFermat VFermat requested review from a team, seancolsen and eito-fis November 18, 2021 00:01
@VFermat
Copy link
Contributor Author

VFermat commented Nov 18, 2021

Checked this as Ready for Review since CodeCov can't be tested on forks.

The workflow should run on this Pull Request and with that we can check if it is working properly!

@kgodey
Copy link
Contributor

kgodey commented Nov 18, 2021

Looks like the coverage report did not upload: https://github.com/centerofci/mathesar/runs/4246068249?check_suite_focus=true

@kgodey
Copy link
Contributor

kgodey commented Nov 19, 2021

@VFermat looks like the upload is still failing: https://github.com/centerofci/mathesar/runs/4258040017?check_suite_focus=true

@kgodey kgodey self-assigned this Nov 19, 2021
@kgodey kgodey added the pr-status: revision A PR awaiting follow-up work from its author after review label Nov 19, 2021
@github-actions
Copy link

github-actions bot commented Jan 3, 2022

This pull request has not been updated in 45 days and is being marked as stale. It will automatically be closed in 30 days if not updated by then.

@github-actions github-actions bot added the stale label Jan 3, 2022
@kgodey kgodey assigned mathemancer and unassigned kgodey Jan 4, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@8e022b3). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #817   +/-   ##
=========================================
  Coverage          ?   97.15%           
=========================================
  Files             ?      162           
  Lines             ?     7852           
  Branches          ?        0           
=========================================
  Hits              ?     7629           
  Misses            ?      223           
  Partials          ?        0           
Flag Coverage Δ
pytest-backend 97.15% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e022b3...397d832. Read the comment docs.

@mathemancer mathemancer mentioned this pull request Jan 10, 2022
7 tasks
@mathemancer
Copy link
Contributor

I unfortunately needed to start a branch in this repo to finish this up. @VFermat thank you very much for your work on this. @kgodey Please continue further review / commenting on the new PR: #966

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: revision A PR awaiting follow-up work from its author after review
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Set up automatic code-coverage reporting for the backend
4 participants