Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use modal confirmation system where possible #857

Merged
merged 11 commits into from
Jan 6, 2022
Merged

Conversation

seancolsen
Copy link
Contributor

@seancolsen seancolsen commented Dec 1, 2021

Details

  • This is a follow up to Set up modal confirmation system #836
  • I used the new modal confirmation system to replace confirmation modals we had previously created manually.
  • I also adjusted the modal confirmation system to allow rich text within confirmation messages.
  • These changes allow us to delete some code and set simpler patterns for contributors to follow going forward.

Notes

  • I added an Identifier.svelte component here. Per a discussion, we'll be adjusting the style within that component, but I think we can handle that in a subsequent PR.
  • My approach to getting rich text into the confirmation messages feels a bit hacky. In React, I'd just use JSX for this sort of thing. This is one of the few areas where I find Svelte to be more awkward.

Review tips

  • Play with deleting a column and deleting a schema since those workflows are now using the new modal confirmation system.
  • Consider if there might be a better way to get rich text into confirmation messages.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the master branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@seancolsen seancolsen requested review from a team, dmos62 and mathemancer and removed request for a team December 1, 2021 16:45
@pavish pavish self-assigned this Dec 2, 2021
@pavish pavish added the pr-status: review A PR awaiting review label Dec 2, 2021
@kgodey kgodey assigned kgodey and unassigned pavish Dec 6, 2021
Base automatically changed from 759_conf to master December 13, 2021 18:17
@pavish pavish self-assigned this Dec 14, 2021
@kgodey kgodey removed their assignment Dec 16, 2021
@kgodey
Copy link
Contributor

kgodey commented Dec 16, 2021

Unassigned myself since @pavish is back.

Copy link
Member

@pavish pavish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seancolsen Looks good to me!

I don't see a clean way to pass down the Identifier, and I'm okay with the approach currently taken.

@pavish pavish merged commit 9e69918 into master Jan 6, 2022
@pavish pavish deleted the conf_instead_of_modal branch January 6, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants