Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean DB type casting extension #980

Merged
merged 2 commits into from
Jan 18, 2022
Merged

Boolean DB type casting extension #980

merged 2 commits into from
Jan 18, 2022

Conversation

mathemancer
Copy link
Contributor

Fixes #387

This adds some strings that can be cast to boolean:

  • yes -> true
  • no -> false
  • y -> true
  • n -> false
  • on -> true
  • off -> false

Technical details

Note that this does not restrict columns to have only two values for inferring boolean. So, a column with '0', '1', 'true', 'TRUE', 'yes', 'off', ... would be inferred to be of boolean DB type. This seems like the best compromise to make at the moment.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the master branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Copy link
Contributor

@silentninja silentninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@kgodey kgodey merged commit b817587 into master Jan 18, 2022
@kgodey kgodey deleted the boolean_details branch January 18, 2022 02:39
@silentninja
Copy link
Contributor

@mathemancer I am able to cast string values('on', 'y') using the default cast, SELECT 'on'::bool' works, any reason why you didn't go for that?. I approved thinking that was not possible

@mathemancer
Copy link
Contributor Author

@silentninja It is possible for all strings we do want to handle. To control things a bit, I wanted to set aside separate "approved" strings (to avoid, e.g., 'of' -> false). For numbers, we need the custom behavior since the ways and types of numbers cast to booleans are a bit confusing in their default state. I'm open to changing the behavior if we want later, but I think the current setup is the best compromise with the current constraints.

@silentninja
Copy link
Contributor

Makes sense, seems extensible too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Handle BOOLEAN data type in the backend
3 participants