Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utf8 encoder speedup for large amounts of data processing #10

Closed
wants to merge 1 commit into from
Closed

Conversation

antelle
Copy link

@antelle antelle commented Jun 3, 2015

Thanks for work!
I have tried to use your package on nodejs to encode/decode 50MB data files but it has consumed too much memory and failed with allocation error. In this pull request, I have replaced arrays with stream processing without double memory consumption and made strings buildup with chunks which increases speed and doesn't bloat V8 GC.
Now it's converting pretty much faster. Also I've added performance test for large amount of data.

@mathiasbynens
Copy link
Owner

Thanks for this patch!

Could you please:

  • respect the existing coding style, i.e. don’t change tabs to spaces
  • don’t bump version numbers
  • make sure the code coverage % remains stable?

Thanks.

@antelle
Copy link
Author

antelle commented Jun 3, 2015

Okay, I'll fix it and resubmit a new pull request tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants