Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utf8 encoder speedup for large amounts of data processing #11

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

antelle
Copy link

@antelle antelle commented Jun 3, 2015

Same as PR #10 but with fixed coverage, code style and versions.

utf8.js Outdated
return utf8;
});
} else if (freeExports && !freeExports.nodeType) {
if (typeof define == 'function' && typeof define.amd == 'object' && define.amd) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change doesn’t belong in this PR.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.32%) to 92.91% when pulling 4e1e9a6 on antelle:master into 792fdab on mathiasbynens:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.54%) to 93.13% when pulling 0ff4e30 on antelle:master into 792fdab on mathiasbynens:master.

@antelle
Copy link
Author

antelle commented Jun 4, 2015

I have removed unrelated formatting modifications and fixed coverage, are you ok with other changes?

@kibertoad
Copy link

@mathiasbynens Any updates on this?..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants