Backend constants #1124
Merged
Backend constants #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in preparation for constant expansion and handling new settign Settings`$PreferredBackendMethod blacken some buffers too.
* Split off segratage Mathemathical constants to its own file. * Add Settings`$PreferredBackendMethod do indicate which kind of constant is preferred.
when precision not not specified or None. Otherwise use PrecsionReal
apply_n() DRY'd Glasher, and Khinchin constants added
rocky
force-pushed
the
backend-constants
branch
from
addcbc7
to
e995426
Compare
mmatera
reviewed
Jan 26, 2021
| manipulate, quantities, numbertheory, numeric, options, patterns, | ||
| plot, physchemdata, randomnumbers, recurrence, specialfunctions, scoping, | ||
| strings, structure, system, tensors, xmlformat, optimization) | ||
| algebra, |
There was a problem hiding this comment.
I wonder if we could DRY this using the list modules we define a few lines below...
|
On Tue, Jan 26, 2021 at 8:53 AM Juan Mauricio Matera < ***@***.***> wrote:
***@***.**** commented on this pull request.
LGTM.
------------------------------
In mathics/builtin/__init__.py
<#1124 (comment)>:
> @@ -3,30 +3,108 @@
from mathics.builtin import (
- algebra, arithmetic, assignment, attributes, calculus, combinatorial, compilation,
- comparison, control, datentime, diffeqns, evaluation, exptrig, functional,
- graphics, graphics3d,
- image, inout, integer, iohooks, linalg, lists, logic,
- manipulate, quantities, numbertheory, numeric, options, patterns,
- plot, physchemdata, randomnumbers, recurrence, specialfunctions, scoping,
- strings, structure, system, tensors, xmlformat, optimization)
+ algebra,
I wonder if we could DRY this using the list modules we define a few
lines below...
We probably can. If you are up to it please commit on top. If not I'll
address over the weekend.
… —
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1124 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAACFE4S3PP4CFEDSTPTCL3S33CMTANCNFSM4WQOB72Q>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Settings`$PreferredBackendMethodto influence how to compute various constants.Blacken some code.
TODO: Add
Methodoption toN[]