-
-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filenames implement #1173
Filenames implement #1173
Conversation
'URLSave[url_String, OptionsPattern[URLSave]]' | ||
return self.apply_2(url, None, evaluation, **options) | ||
|
||
def apply_2(self, url, filename, evaluation, **options): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something to think about for the future. I know the convention we've been using is apply with a number afterwards, but I think things would be more meaningful if put something more descriptive in there like apply_with_filename_parameter()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - you can do the merge when you are ready.
After that is in I'll look over in Windows and rebase the windows-compatibility branch off of this, looking to see if there is anything that got fixed.
This PR adds
FileNames
, a symbol required in theFeynCalc
package (see #1169)