Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement NumberForm #455

Merged
merged 19 commits into from Jul 20, 2016
Merged

implement NumberForm #455

merged 19 commits into from Jul 20, 2016

Conversation

sn6uv
Copy link
Member

@sn6uv sn6uv commented Jul 15, 2016 •
edited

TODO:

  • fix passing functions as options e.g. ExponentFunction.
  • Quotient
  • handle Integer expr.
  • zero case.
  • replace Real.make_boxes.
  • ScientificForm, AccountingForm, EngineeringForm?

@sn6uv sn6uv mentioned this pull request Jul 15, 2016
Merged
@sn6uv
Copy link
Member Author

sn6uv commented Jul 15, 2016 •
edited

The failed test is a Cython bug with python2: docstrings with non-ascii characters in them cause a crash when trying to find the tests. Error at doc/doc.py line 765.
Workaround: move NumberForm to another module that isn't compiled with cython.

@sn6uv sn6uv merged commit 1220714 into mathics:master Jul 20, 2016
@sn6uv sn6uv deleted the NumberForm branch July 20, 2016 22:25
@sn6uv sn6uv mentioned this pull request Sep 25, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@sn6uv