Graph[] #600
Graph[] #600
Conversation
There was a problem hiding this comment.
Overall good. I'm very happy to see graphs being finally added.
Quite a few missing edge cases, in particular the empty graph.
It's not clear which parts of networkx require numpy, certainly some of the layout stuff does. A defensive approach would be to require numpy for _NetworkXBuiltin but maybe we don't need to since most of it works without numpy.
|
|
||
|
|
||
| class UndirectedEdge(Builtin): | ||
| pass |
There was a problem hiding this comment.
Docs missing. Maybe a good place to test the parsing of <->.
|
I'd tentatively like to suggest including this in 1.0 but if it's not ready then that's okay too. |
| #> PathGraphQ[Graph[{1 -> 2, 2 -> 1}]] | ||
| = True | ||
| #> PathGraphQ[Graph[{}]] | ||
| = False |
|
Note: Now that #604 is merged the graph tests should now run on Travis. |
|
Let's leave this for the next release. |
poke1024
force-pushed
the
graph
branch
2 times, most recently
from
5dc432b
to
bda3939
Compare
|
@poke1024 Hey, would you be willing to rebase this branch so that we can finally merge it? |
|
@poke1024 Thanks for the rebase! It looks like most failing tests are caused by |
|
@GarkGarcia I'm currently looking into this. |
GarkGarcia
dismissed
sn6uv’s stale review
All tests have passed, so I believe we're good.
|
Great! Thanks for your contribution! |
Still a work in progress, but already usable.