Propery handle placement of scripts on \vcenter, \vbox, and \vtop (mathjax/MathJax#3091) #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem where super- and subscripts were not placed properly on the results of
\vcenter,\vbox, and\vtopelements. These are implemented usingmpaddednodes withdata-vertical-alignattributes and avboxproperty to mark them as vboxes. The problem is that thegetBaseCore()method should stop at anmpaddedelement being used as a vbox, but was continuing down into it incorrectly if there was only one child element. The fix is to stop when thempaddedhas thevboxproperty.Resolves issue mathjax/MathJax#3091.