Prevent setting a propery that has a getter. (mathjax/MathJax#3098) #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zorkow
approved these changes
Sep 14, 2023
ts/components/global.ts
Outdated
| * @param {any} src The source configuration object (to replace defaul values in dst} | ||
| * @return {any} The resulting (modified) config object | ||
| * @param {any} dst The destination config object (to be merged into) | ||
| * @param {any} src The source configuration object (to replace defaul values in dst} |
ts/components/global.ts
Outdated
| * @return {any} The resulting (modified) config object | ||
| * @param {any} dst The destination config object (to be merged into) | ||
| * @param {any} src The source configuration object (to replace defaul values in dst} | ||
| * @param {boolean} check True when combining into MathJax._ to avoid setting getter properties |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves a problem that occurs when
combineConfig()orcombineWithMathJax()are used to merge an object into theMathJax._object and the item to be set is already set and has a getter. This occurs due to the way exports are handled in ESM modules, where the exports are in an object each with a getter (so that they can't be modified, as imports are supposed to be immutable). That didn't seem to be the case for the CJS components we used to use. As a consequence, changing the renderer now causes an error since both the CHTML and SVG components include the common output code, and both set the properties ofMathJax._.output.common, which are all getters. This produces errors.Resolves the console error issue from mathjax/MathJax#3098.